Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58235 )
Change subject: mb/intel/adlrvp: Remove EC region
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
@rizwan/sridhar: hows its been done for ADL-P RVP ?
Hello @Rizwan, answers below:
Q:was EC region being used as padding to make CSE region addresses to align to a certain boundary?
A: No, by analyzing images I noticed that EC binaries were not included. This caused the mismatch with FMAP.
Q:or calculating offset for CSE RW partition for FW update was being affected due to the presence of EC region?
A: Yes, EC region was presence in fmd file but actual binaries were not present in image, this caused an error in calculating CSE RW address that was preventing platform from booting due to reboot loop.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58235
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic76c29069beb510dd7620f340e0aab212668c3f3
Gerrit-Change-Number: 58235
Gerrit-PatchSet: 2
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: AndreX Andraos
andrex.andraos@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Tue, 26 Oct 2021 17:04:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-MessageType: comment