Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46031 )
Change subject: drivers/intel/wifi: Use newly added pci_dev_log_wake ......................................................................
drivers/intel/wifi: Use newly added pci_dev_log_wake
This change uses the newly added `pci_dev_log_wake()` helper function to determine and log WiFi wake source instead of assuming a hard-coded register value to check. This is done in preparation to merge the generic WiFi and Intel WiFi drivers in coreboot in follow up changes.
BUG=b:169802515 BRANCH=zork
Change-Id: I9bdb453092b4ce7bdab2969f13e0c0aa8166dc0a Signed-off-by: Furquan Shaikh furquan@google.com --- M src/drivers/intel/wifi/wifi.c 1 file changed, 1 insertion(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/46031/1
diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c index e117ec0..f768b04 100644 --- a/src/drivers/intel/wifi/wifi.c +++ b/src/drivers/intel/wifi/wifi.c @@ -10,9 +10,6 @@ #include "chip.h" #include "drivers/wifi/generic/chip.h"
-#define PMCS_DR 0xcc -#define PME_STS (1 << 15) - #if CONFIG(GENERATE_SMBIOS_TABLES) static int smbios_write_wifi(struct device *dev, int *handle, unsigned long *current) @@ -63,12 +60,7 @@
static void wifi_pci_dev_init(struct device *dev) { - if (CONFIG(ELOG)) { - uint32_t val; - val = pci_read_config16(dev, PMCS_DR); - if (val & PME_STS) - elog_add_event_wake(ELOG_WAKE_SOURCE_PME_WIFI, 0); - } + pci_dev_log_wake(dev, ELOG_WAKE_SOURCE_PME_WIFI, 0); }
struct device_operations device_ops = {