Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44050 )
Change subject: soc/intel/tigerlake: Clean up report_cpu_info() function ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44050/1/src/soc/intel/tigerlake/boo... File src/soc/intel/tigerlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/44050/1/src/soc/intel/tigerlake/boo... PS1, Line 112: microcode_ver.lo = 0; : microcode_ver.hi = 0; : wrmsr(BIOS_SIGN_ID, microcode_ver); u can remove this too
https://review.coreboot.org/c/coreboot/+/44050/1/src/soc/intel/tigerlake/boo... PS1, Line 116: microcode_ver = rdmsr(BIOS_SIGN_ID); u can remove this
https://review.coreboot.org/c/coreboot/+/44050/1/src/soc/intel/tigerlake/boo... PS1, Line 127: printk(BIOS_DEBUG, "CPU: ID %x, %s, ucode: %08x\n", : cpu_id, cpu_type, microcode_ver.hi); printk(BIOS_DEBUG, "CPU: ID %x, %s, ucode: %08x\n", cpu_id, cpu_type, get_current_microcode_rev());