Attention is currently required from: Felix Held, Fred Reitberger, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75645?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: libpayload/drivers/usb/xhci.c: Check for NULL in xhci_init
......................................................................
Patch Set 2:
(1 comment)
File payloads/libpayload/drivers/usb/xhci.c:
https://review.coreboot.org/c/coreboot/+/75645/comment/0fa19fa6_ce0b4a52 :
PS1, Line 158: if (!physical_bar)
: goto _exit_xhci;
That is the case. […]
Could you please add that information to the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75645?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05c32612606793adcba3f4a5724092387a215d41
Gerrit-Change-Number: 75645
Gerrit-PatchSet: 2
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 06 Jun 2023 19:00:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment