Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32394 )
Change subject: riscv: add support for OpenSBI ......................................................................
Patch Set 14:
(5 comments)
https://review.coreboot.org/c/coreboot/+/32394/4/payloads/Kconfig File payloads/Kconfig:
https://review.coreboot.org/c/coreboot/+/32394/4/payloads/Kconfig@31 PS4, Line 31: config PAYLOAD_RISCV_LINUX_BINARY
Yes! You are right.
Done
https://review.coreboot.org/c/coreboot/+/32394/4/src/arch/riscv/Makefile.inc File src/arch/riscv/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/32394/4/src/arch/riscv/Makefile.inc... PS4, Line 193: FW_PAYLOAD_PATH=$(abspath $(CONFIG_PAYLOAD_FILE))
This is simple. […]
Done
https://review.coreboot.org/c/coreboot/+/32394/11/src/arch/riscv/opensbi.c File src/arch/riscv/opensbi.c:
https://review.coreboot.org/c/coreboot/+/32394/11/src/arch/riscv/opensbi.c@3... PS11, Line 39: :"r"(hart_id), "r"(fdt), "r"(&info)
spaces required around that ':' (ctx:ExV)
Done
https://review.coreboot.org/c/coreboot/+/32394/11/src/arch/riscv/opensbi.c@4... PS11, Line 40: :"a0", "a1", "a2");
spaces required around that ':' (ctx:ExV)
Done
https://review.coreboot.org/c/coreboot/+/32394/4/src/soc/sifive/fu540/Kconfi... File src/soc/sifive/fu540/Kconfig:
https://review.coreboot.org/c/coreboot/+/32394/4/src/soc/sifive/fu540/Kconfi... PS4, Line 56: endif
Done in the next commits
Done