Attention is currently required from: Arthur Heymans, Raul Rangel, Tristan Corrick, Alexander Couzens, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58604 )
Change subject: cpu/intel/haswell: Remove the fake lapic
......................................................................
Patch Set 1:
(2 comments)
File src/cpu/intel/haswell/acpi.c:
https://review.coreboot.org/c/coreboot/+/58604/comment/b68bc784_bfc92816
PS1, Line 175: s0ix_enable
Thanks for the explanation. […]
Now that I think of it, a `config_of_cpu()` helper would be useful to have.
File src/cpu/intel/haswell/haswell_init.c:
https://review.coreboot.org/c/coreboot/+/58604/comment/1eefb1b1_7fa0ec0b
PS1, Line 182: struct cpu_info *info = cpu_info();
: if (!info)
: return;
It should never return a NULL pointer.
Yes, I checked the code and saw that something would need to go very wrong for `cpu_info()` to return a null pointer. I was pointing out the inconsistent usage of null checks. So, this check can be dropped.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69f9c1fe71a773e1fba0942d8a785b6ad26dd9a0
Gerrit-Change-Number: 58604
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 15 Nov 2021 13:04:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment