Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: mb/asus: Add ASUS H110M-E/M.2 mainboard ......................................................................
Patch Set 76:
(6 comments)
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... PS76, Line 71: huh? what's that?
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... PS76, Line 205: chip superio/nuvoton/nct5539d : device pnp 2e.2 on # UART A : misaligned
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... PS76, Line 188: that's not intended, is it?
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... PS76, Line 234: DDPB_CTRLDATA why not at EOL?
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... PS76, Line 236: DDPC_CTRLCLK same
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... PS76, Line 238: DDPC_CTRLDATA same