Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34632 )
Change subject: Documentation: Add guidelines for new mainboard ports ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... File Documentation/getting_started/mainboard_template.md:
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 24: * 'EVT early prototype' (Unit is for 'Engineering validation test') : * 'DVT prototype' (Unit is for 'Design verification test')
This is generally confidential information, and is generally only a few months apart.
I don't see why we should let the documentation rot for "a few" month. It should be as accurate as possible, as there's no other source of information.
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 30: * What's the expected release date?
This is also confidential information
I don't see why releasing hardware specs (by pushing source code) is NOT confidential, but the release date should be. You can still answer this question with: "in the future"
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... File Documentation/getting_started/new_mainboard_ports.md:
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 56: Provide good documentation, see point 4
This was discussed in the coreboot leadership meeting, and while desirable, documentation is NOT a r […]
Nothing to comment here.
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 63: What you should **not** document:
Why?
Violates https://doc.coreboot.org/getting_started/writing_documentation.html point 9.
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 68: Recommended a flashing method as described in [Flashing tutorial]
Doesn't this directly contradict point 5?
No, instead of duplication how to use "flashrom -p internal" on every mainboard, you'd just reference existing documentation.