build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33388 )
Change subject: sb/intel/spi: Check for the SPI lock bit during runtime ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/33388/2/src/southbridge/intel/common/spi.c File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/#/c/33388/2/src/southbridge/intel/common/spi.c@3... PS2, Line 339: return !!(readw_(&cntlr->ich7_spi->spis) & HSFS_FLOCKDN); code indent should use tabs where possible
https://review.coreboot.org/#/c/33388/2/src/southbridge/intel/common/spi.c@3... PS2, Line 341: return !!(readw_(&cntlr->ich9_spi->hsfs) | HSFS_FLOCKDN) ; code indent should use tabs where possible
https://review.coreboot.org/#/c/33388/2/src/southbridge/intel/common/spi.c@3... PS2, Line 341: return !!(readw_(&cntlr->ich9_spi->hsfs) | HSFS_FLOCKDN) ; space prohibited before semicolon