Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45059 )
Change subject: soc/amd/picasso: pass verstage timestamps to x86 ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45059/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45059/6//COMMIT_MSG@16 PS6, Line 16: Adding value directly to TSC can sovle it, it will be kept across nit "solve"
https://review.coreboot.org/c/coreboot/+/45059/6/src/soc/amd/picasso/bootblo... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45059/6/src/soc/amd/picasso/bootblo... PS6, Line 124: struct transfer_info_struct *info = (struct transfer_info_struct *) this assumes I have a transfer buffer set up. What if I don't? What if vboot is running after boot block? Should this be after the if-config check?