Hello caveh jalali,
I'd like you to do a code review. Please visit
https://review.coreboot.org/27128
to review the following change.
Change subject: atlas: enable camera power and release reset ......................................................................
atlas: enable camera power and release reset
This is a temporary hack to test camera presence before we have full camera support implemented. Basically, we can now probe the camera over i2c to verify that it's connected and the camera LED turns on.
BUG=b:80106316 BRANCH=none TEST=camera LED comes on and camera can be probed over i2c.
Change-Id: Ibaabf6c6f6a1dabaddd2fc47c820e090ca5984a5 Signed-off-by: Caveh Jalali caveh@chromium.org --- M src/mainboard/google/poppy/variants/atlas/gpio.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/27128/1
diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c index 3a7b722..b374265 100644 --- a/src/mainboard/google/poppy/variants/atlas/gpio.c +++ b/src/mainboard/google/poppy/variants/atlas/gpio.c @@ -177,7 +177,7 @@ /* D7 : ISH_I2C1_SDA ==> SPKR_IRQ_L */ PAD_CFG_GPI_APIC(GPP_D7, NONE, PLTRST), /* D8 : ISH_I2C1_SCL ==> EN_CAMERA_PWR */ - PAD_CFG_GPO(GPP_D8, 0, DEEP), + PAD_CFG_GPO(GPP_D8, 1, DEEP), /* D9 : ISH_SPI_CS# ==> ISH_SPI_CS_L */ PAD_CFG_NF_1V8(GPP_D9, NONE, DEEP, NF1), /* D10 : ISH_SPI_CLK ==> ISH_SPI_CLK */ @@ -195,9 +195,9 @@ /* D16 : ISH_UART0_CTS# ==> NC */ PAD_CFG_NC(GPP_D16), /* D17 : DMIC_CLK1 ==> PCH_CAMERA_RESET */ - PAD_CFG_GPO(GPP_D17, 0, DEEP), + PAD_CFG_GPO(GPP_D17, 1, DEEP), /* D18 : DMIC_DATA1 ==> PCH_CAMERA_CLOCK_ENABLE */ - PAD_CFG_GPO(GPP_D18, 0, DEEP), + PAD_CFG_GPO(GPP_D18, 1, DEEP), /* D19 : DMIC_CLK0 ==> PCH_DMIC_CLK_OUT */ PAD_CFG_NF(GPP_D19, NONE, DEEP, NF1), /* D20 : DMIC_DATA0 ==> PCH_DMIC_DATA_IN */