Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )
Change subject: lib/edid_fill_fb: Support multiple framebuffers ......................................................................
Patch Set 21:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39002/21//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39002/21//COMMIT_MSG@14 PS21, Line 14: + add spaces around +
https://review.coreboot.org/c/coreboot/+/39002/21//COMMIT_MSG@15 PS21, Line 15: + add spaces around +
https://review.coreboot.org/c/coreboot/+/39002/21/src/lib/edid_fill_fb.c File src/lib/edid_fill_fb.c:
https://review.coreboot.org/c/coreboot/+/39002/21/src/lib/edid_fill_fb.c@167 PS21, Line 167: //TODO: Add support for advertising all framebuffers in this list TODO
https://review.coreboot.org/c/coreboot/+/39002/21/src/mainboard/google/kukui... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39002/21/src/mainboard/google/kukui... PS21, Line 148: static bool configure_display(void) : { : struct panel_description *panel = get_active_panel(); : if (!panel) : return false; : : mtcmos_display_power_on(); : mtcmos_protect_display_bus(); : configure_panel_backlight(); : power_on_panel(panel); : : struct edid *edid = &panel->s->edid; : edid_set_framebuffer_bits_per_pixel(edid, 32, 0); : mtk_ddp_init(); : u32 mipi_dsi_flags = (MIPI_DSI_MODE_VIDEO | : MIPI_DSI_MODE_VIDEO_SYNC_PULSE | : MIPI_DSI_MODE_LPM); : if (CONFIG(DRIVER_ANALOGIX_ANX7625)) : mipi_dsi_flags |= MIPI_DSI_MODE_EOT_PACKET; : if (mtk_dsi_init(mipi_dsi_flags, MIPI_DSI_FMT_RGB888, 4, edid, : panel->s->init) < 0) { : printk(BIOS_ERR, "%s: Failed in DSI init.\n", __func__); : return false; : } : mtk_ddp_mode_set(edid); : struct fb_info *info = set_vbe_mode_info_valid(edid, 0); : if (info) : fb_set_orientation(info, panel->s->orientation); : : return true; : } : is this really board-specific or should it be moed to some driver?