Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47395 )
Change subject: elog: Add new wake source codes ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47395/1/src/include/elog.h File src/include/elog.h:
https://review.coreboot.org/c/coreboot/+/47395/1/src/include/elog.h@123 PS1, Line 123: #define ELOG_WAKE_SOURCE_PME_TBT 0x2d This change will also be required in mosys.
https://review.coreboot.org/c/coreboot/+/47395/1/src/include/elog.h@126 PS1, Line 126: ELOG_WAKE_SOURCE_PME_TCSS_DMA0 Do we want to handle this like it is done for XHCI? i.e. add event DMA with instance # so that if we have more DMA controllers in the future, we don't need to add more wake source types for them.