Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35605 )
Change subject: util/mb/google/hatch: fix style issues in shell script
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35605/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35605/3//COMMIT_MSG@9
PS3, Line 9: Use all caps for variables.
: Use a single exit code for failures.
: No need to popd before exiting the script.
: Do ${var,,} and ${var^^} into variables instead of using it everywhere.
: Add more punctuation in comments.
Please format this as a list.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35605
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63aa0aa633f36b9543e809fc42fac955da5960a3
Gerrit-Change-Number: 35605
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Andrew McRae
amcrae@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Sep 2019 15:50:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment