Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45258 )
Change subject: sb/intel/bd82x6x: Only check device ID in `intel_me_finalize_smm` ......................................................................
sb/intel/bd82x6x: Only check device ID in `intel_me_finalize_smm`
There's no need to compare the vendor ID.
Change-Id: I4368f2615e5ce72430992f1f5581908c90c970f0 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45258 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/bd82x6x/me.c 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/southbridge/intel/bd82x6x/me.c b/src/southbridge/intel/bd82x6x/me.c index c51cca6..3876b02 100644 --- a/src/southbridge/intel/bd82x6x/me.c +++ b/src/southbridge/intel/bd82x6x/me.c @@ -168,16 +168,16 @@
void intel_me_finalize_smm(void) { - u32 did = pci_read_config32(PCH_ME_DEV, PCI_VENDOR_ID); + u16 did = pci_read_config16(PCH_ME_DEV, PCI_DEVICE_ID); switch (did) { - case 0x1c3a8086: + case 0x1c3a: intel_me7_finalize_smm(); break; - case 0x1e3a8086: + case 0x1e3a: intel_me8_finalize_smm(); break; default: - printk(BIOS_ERR, "No finalize handler for ME %08x.\n", did); + printk(BIOS_ERR, "No finalize handler for ME %04x.\n", did); } }