[coreboot-gerrit] Change in ...coreboot[master]: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27089 )

Change subject: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant
......................................................................

Patch Set 9: Code-Review-1

(1 comment)

https://review.coreboot.org/#/c/27089/9/src/mainboard/asus/p5qpl-am/romstage... 
File src/mainboard/asus/p5qpl-am/romstage.c:

https://review.coreboot.org/#/c/27089/9/src/mainboard/asus/p5qpl-am/romstage... 
PS9, Line 70: static int setup_sio_gpio(void)
> My opinion is this would have been worth two separate functions, one for each variant. […]

Um, yes, the current function is ugly at best. So this would be a romstage.c in each variant dir and a makefile.inc entry to gain readability. Sounds wise.