Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34333 )
Change subject: arch/x86/acpi.c: Change TPM2 ACPI Table to support CRB
......................................................................
Patch Set 23:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34333/23/src/arch/x86/acpi.c
File src/arch/x86/acpi.c:
https://review.coreboot.org/c/coreboot/+/34333/23/src/arch/x86/acpi.c@391
PS23, Line 391: tpm2->control_area = CONFIG_CRB_TPM_BASE_ADDRESS + 0x40;
+ 0x40 seems Intel PTT specific.
The Tcg doesn't specify the offset, does it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34333
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide3af348fd4676f2d04e1d0b9ad83f9124e09dcc
Gerrit-Change-Number: 34333
Gerrit-PatchSet: 23
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 29 Jul 2019 17:24:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment