[coreboot-gerrit] [XS] Change in coreboot[main]: mb/google/rauru: Determine PCIe init by storage type

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85828?usp=email )

Change subject: mb/google/rauru: Determine PCIe init by storage type
......................................................................

Patch Set 3:

(2 comments)

File src/mainboard/google/rauru/mainboard.c:

https://review.coreboot.org/c/coreboot/+/85828/comment/93132861_56f5fd4b?usp... :
PS2, Line 52: 	return storage_id() == 3;
> That's it.

Acknowledged

File src/mainboard/google/rauru/mainboard.c:

https://review.coreboot.org/c/coreboot/+/85828/comment/f874273e_248ea95e?usp... :
PS3, Line 72: _BASE_TYPE_NVME
Variables starting with `_` are private to that file. Use `STORAGE_NVME` here.

Or, if you'd like to make it more general, rename `_BASE_TYPE` to `STORAGE_BASE_TYPE`, rename `_BASE_TYPE_NVME` to `STORAGE_BASE_TYPE_NVME`, and write `STORAGE_BASE_TYPE(mainboard_get_storage_type()) == STORAGE_BASE_TYPE_NVME` here.

Or, add `mainboard_storage_is_nvme()`.