Attention is currently required from: Raul Rangel, Martin Roth, Karthik Ramasubramanian, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56499 )
Change subject: mb/google/guybrush: Update GPIOs for fingerprint
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56499/comment/d6acb751_5c016d8a
PS2, Line 7: fingerprint
fingerprint sensor?
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/56499/comment/3ec80c9d_f3e5ee37
PS2, Line 374: /* FPMCU_RST_L */
: PAD_NC(GPIO_11),
: /* EN_PWR_FP */
: PAD_NC(GPIO_32),
One indentation level too much?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56499
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaae5feec60abb2480777d1f99174254c5132bb43
Gerrit-Change-Number: 56499
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 06 Aug 2021 07:40:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
