[coreboot-gerrit] Change in coreboot[master]: soc/intel/alderlake: Refactor meminit code

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48860 )

Change subject: soc/intel/alderlake: Refactor meminit code
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48860/2/src/soc/intel/alderlake/mem... 
File src/soc/intel/alderlake/meminit.c:

https://review.coreboot.org/c/coreboot/+/48860/2/src/soc/intel/alderlake/mem... 
PS2, Line 100: init_dq_upds
> BTW, what do you think about this: […]

Above can be further simplified by eliminating init_dq_upds()/init_dqs_upds() completely too.

static void *fspm_dq_upd_ptrs[] = {
       &mem_cfg->DqMapCpu2DramCh0,
       &mem_cfg->DqMapCpu2DramCh1,
       &mem_cfg->DqMapCpu2DramCh2,
       &mem_cfg->DqMapCpu2DramCh3,
       &mem_cfg->DqMapCpu2DramCh4,
       &mem_cfg->DqMapCpu2DramCh5,
       &mem_cfg->DqMapCpu2DramCh6,
       &mem_cfg->DqMapCpu2DramCh7,
};

for (i = 0; i < total_pairs; i++, dq_map_ptr++) {
     void *upd_ptr = fspm_dq_upd_ptrs[i];

memcpy(upd_ptr, dq_map_ptr.dq0, BITS_PER_BYTE);
     memcpy((char *)upd_ptr + BITS_PER_BYTE, dq_map_ptr.dq1, BITS_PER_BYTE);
}

for (; i < TOTAL_BYTE_PAIRS; i++) {
     void *upd_ptr = fspm_dq_upd_ptrs[i];

memset(upd_ptr, 0, 2 * BITS_PER_BYTE);
}