Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35968 )
Change subject: mainboard/ocp/monolake: Hide IIO root ports before memory init ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35968/2/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/35968/2/src/mainboard/ocp/monolake/... PS2, Line 29: include <soc/ubox.h>
Is this change related to the described patch? Or do you just clean it up here? […]
Ack
https://review.coreboot.org/c/coreboot/+/35968/2/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/35968/2/src/soc/intel/fsp_broadwell... PS2, Line 119: 0
You could use here %d and then provide BUS0 as parameter to be consistent. […]
Ack
https://review.coreboot.org/c/coreboot/+/35968/2/src/soc/intel/fsp_broadwell... PS2, Line 119: .
:
Ack
https://review.coreboot.org/c/coreboot/+/35968/2/src/soc/intel/fsp_broadwell... PS2, Line 158: Call
Move below early_iio_hide()
Ack
https://review.coreboot.org/c/coreboot/+/35968/2/src/soc/intel/fsp_broadwell... PS2, Line 163: early_iio_hide
Add comment explaining why it's done here.
Ack