Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18548 )
Change subject: nb/intel/i945: Program CxODT value for each channel
......................................................................
Patch Set 32:
(2 comments)
https://review.coreboot.org/c/coreboot/+/18548/31/src/northbridge/intel/i945...
File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/18548/31/src/northbridge/intel/i945...
PS31, Line 2442: printk(BIOS_DEBUG, "one dimm per channel config..\n");
True. My bad. […]
If both channels are not populated, we have a much more serious problem...
https://review.coreboot.org/c/coreboot/+/18548/31/src/northbridge/intel/i945...
PS31, Line 2434: u8 dimm_mask = 0;
What does the `dimm_mask` do? Add a comment?
It just packs the DIMM presence into a bitfield. I'd just shorten the name of SYSINFO_DIMM_NOT_POPULATED instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/18548
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aec35f45250da554ddc5a68f5add157c313399c
Gerrit-Change-Number: 18548
Gerrit-PatchSet: 32
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Sat, 14 Mar 2020 20:42:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment