[coreboot-gerrit] Change in coreboot[master]: nb/intel/i945: Program CxODT value for each channel

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18548 )

Change subject: nb/intel/i945: Program CxODT value for each channel
......................................................................

Patch Set 32:

(2 comments)

https://review.coreboot.org/c/coreboot/+/18548/31/src/northbridge/intel/i945... 
File src/northbridge/intel/i945/raminit.c:

https://review.coreboot.org/c/coreboot/+/18548/31/src/northbridge/intel/i945... 
PS31, Line 2442: 		printk(BIOS_DEBUG, "one dimm per channel config..\n");
> True. My bad. […]

If both channels are not populated, we have a much more serious problem...

https://review.coreboot.org/c/coreboot/+/18548/31/src/northbridge/intel/i945... 
PS31, Line 2434: 	u8 dimm_mask = 0;
> What does the `dimm_mask` do? Add a comment?

It just packs the DIMM presence into a bitfield. I'd just shorten the name of SYSINFO_DIMM_NOT_POPULATED instead.