Attention is currently required from: Julius Werner, Yu-Ping Wu.
Douglas Anderson has posted comments on this change by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/85964?usp=email )
Change subject: commonlib/device_tree: Return cells properties of parent node ......................................................................
Patch Set 1:
(1 comment)
File src/commonlib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/85964/comment/de8c5b01_312b6d12?usp... : PS1, Line 1061:
path is not allowed to be `NULL`. At the very least it must be `{ NULL }`. […]
Right, by "points to NULL" I meant `path` was `{ NULL }`.
Sure, it's useless for the purpose of finding a child DT node, but what if old code was using this function as a shortcut for finding the `#address-cells` and `#size-cells` of a given node. AKA:
``` u32 sizecells, addrcells;
dt_find_node(np, { NULL }, &addrcells, &sizecells, false); ```
That would have done _something_ prior to this change. Even if it returned the wrong value (because it should have been the parent's value) it was still something. Now it's just leaving uninitialized values.
I'm not saying that I've done any research to see if anyone did that. It is just a change in functionality and, without digging deeply, it's something to point out so people more familiar with the callers can say "yes, we believe this is OK" or "hmmm, maybe we should make a wrapper to catch people doing that". I'm happy to leave it up to others to make the call.