[coreboot-gerrit] Change in ...coreboot[master]: intel/apollolake: Add parameter to enable VTD in devicetree

[Werner Zeh (Code Review)]

Werner Zeh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31194 )

Change subject: intel/apollolake: Add parameter to enable VTD in devicetree
......................................................................

intel/apollolake: Add parameter to enable VTD in devicetree

The FSP has a parameter to enable or disable the VTD feature
(Intel's Virtualization Technology for Directed I/O). In current header
files for FSP-S (Apollo Lake and Gemini Lake) this parameter is set to
disabled per default. Therefore, if the FSP was not modified via BCT,
this feature is most likely disabled on all mainboards.

Add a chip parameter so that VTD can be enabled on mainboard level in
devicetree and therefore this feature can be activated if needed.

Change-Id: Ic0bfcf1719e1ccc678a932bf3d38c6dbce3556bc
Signed-off-by: Werner Zeh 
Reviewed-on: https://review.coreboot.org/c/31194
Reviewed-by: Furquan Shaikh 
Reviewed-by: Nico Huber 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/apollolake/chip.c
M src/soc/intel/apollolake/chip.h
2 files changed, 9 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index de33e82..3634509 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -754,6 +754,9 @@
    if (!xdci_can_enable())
    	dev->enabled = 0;
    silconfig->UsbOtg = dev->enabled;
+
+	/* Set VTD feature according to devicetree */
+	silconfig->VtdEnable = cfg->enable_vtd;
 }

struct chip_operations soc_intel_apollolake_ops = {
diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h
index 6c2404a..b9e368c 100644
--- a/src/soc/intel/apollolake/chip.h
+++ b/src/soc/intel/apollolake/chip.h
@@ -188,6 +188,12 @@
     * 00=1.10v, 01=1.15v, 10=1.24v, 11=1.20v (default).
     */
    uint32_t PmicVdd2Voltage;
+
+	/* Option to enable VTD feature. Default is 0 which disables VTD
+	 * capability in FSP. Setting this option to 1 in devicetree will enable
+	 * the Upd parameter VtdEnable.
+	 */
+	uint8_t enable_vtd;
 };

typedef struct soc_intel_apollolake_config config_t;