[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Disable ACPI PM Timer due to power impact in S0ix

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34506 )

Change subject: soc/intel/cannonlake: Disable ACPI PM Timer due to power impact in S0ix
......................................................................

Patch Set 4: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/34506/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34506/4//COMMIT_MSG@7 
PS4, Line 7: soc/intel/cannonlake: Disable ACPI PM Timer due to power impact in S0ix
Maybe:
> Disable ACPI PM timer to reduce S0ix power usage

https://review.coreboot.org/c/coreboot/+/34506/4//COMMIT_MSG@8 
PS4, Line 8: 
Maybe add that the TCO timer is used instead (was it before)?

Did you measure the power difference?