Attention is currently required from: Michał Żygowski, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75462?usp=email )
Change subject: [RFC] security/vboot/misc.h: Always return slot A if RW_AB not enabled ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: I'm not sure this really makes sense? You won't affect vboot bookkeeping with this, so vboot will still think it needs to reboot and try slot B first before going into recovery mode and all those kinds of things. So I don't think this actually makes the extra reboots go away.
A proper solution for this I think would be to add a new VB2_CONTEXT_ONLY_ONE_SLOT flag in https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/refs..., to let vboot know properly that it is supposed to run in single slot mode. And then modify vb2_select_fw_slot() and vb2api_fail() (in https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/refs...) accordingly, so that it will behave correctly in slot failure cases (not try to reboot into the other slot first but go straight into recovery).