Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37707 )
Change subject: mainboard/intel/common: Add some common board and memory APIs ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37707/4/src/mainboard/intel/common/... File src/mainboard/intel/common/board/board_id.c:
https://review.coreboot.org/c/coreboot/+/37707/4/src/mainboard/intel/common/... PS4, Line 24: uint32_t why use a variable of different signature from the return type?
https://review.coreboot.org/c/coreboot/+/37707/4/src/mainboard/intel/common/... PS4, Line 38: if (CONFIG(EC_GOOGLE_CHROMEEC)) : id = get_board_id_via_ext_ec(); : else use brackets on if condition too.
https://review.coreboot.org/c/coreboot/+/37707/4/src/mainboard/intel/common/... PS4, Line 40: { space before.
https://review.coreboot.org/c/coreboot/+/37707/4/src/mainboard/intel/common/... PS4, Line 45: buffer[index] = recv_ec_data(); id |= recv_ec_data() << (8 * (1 - index)); after clearing id?
https://review.coreboot.org/c/coreboot/+/37707/4/src/mainboard/intel/common/... File src/mainboard/intel/common/memory/spd.c:
https://review.coreboot.org/c/coreboot/+/37707/4/src/mainboard/intel/common/... PS4, Line 23: remove newline.