[coreboot-gerrit] Change in coreboot[master]: src/acpi/acpigen_usb.c: Fix False Memory leak error

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, vaibhav.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62968 )

Change subject: src/acpi/acpigen_usb.c: Fix False Memory leak error
......................................................................

Patch Set 2:

(2 comments)

Patchset:

PS2: 
+ some other folks for other opinions on clang_analyzer

File src/acpi/acpigen_usb.c:

https://review.coreboot.org/c/coreboot/+/62968/comment/36a44ba0_2fe3ce3e 
PS2, Line 92: #ifdef __clang_analyzer__
            : 	free(fresh);
            : 	#endif
Hmm, right now we do not have any instances of this in the code I can found, other than vendorcode, not sure if this is worth cluttering up the code with or not. The whole heap area is kept in CBMEM and marked as RESERVED in cbmem table (which most payloads recognize as RESERVED for e820 map), thus there can't be any leaks, by definition, so it seems that just ignoring these may be the best course.