build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )
Change subject: amdfwtool: Take a config file instead of command line parameters ......................................................................
Patch Set 35:
(8 comments)
https://review.coreboot.org/c/coreboot/+/42859/35/util/amdfwtool/amdfwtool-b... File util/amdfwtool/amdfwtool-b.c:
https://review.coreboot.org/c/coreboot/+/42859/35/util/amdfwtool/amdfwtool-b... PS35, Line 169: printf("-A | --combo-capable Place PSP directory pointer at Embedded Firmware\n"); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/35/util/amdfwtool/amdfwtool-b... PS35, Line 196: printf("-I | --instance <number> Sets instance field for the next BIOS firmware\n"); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/35/util/amdfwtool/amdfwtool-b... PS35, Line 217: printf("-P | --sharedmem-size Maximum size of the PSP/FW shared memory area\n"); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/35/util/amdfwtool/amdfwtool-b... PS35, Line 219: printf(" Stoneyridge, Raven, Picasso, Renoir or Lucienne"); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/35/util/amdfwtool/amdfwtool-b... PS35, Line 241: printf(" 0x2 Micron parts optional, this option is only\n"); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/35/util/amdfwtool/amdfwtool-b... PS35, Line 952: printf("Error: BIOS binary destination and uncompressed size are required\n"); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/35/util/amdfwtool/amdfwtool-b... PS35, Line 957: printf("Error: BIOS binary assumed outside amdfw.rom but no source address given\n"); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/35/util/amdfwtool/amdfwtool-b... PS35, Line 1091: static const char *optstring = "x:i:g:AMS:p:b:s:r:k:c:n:d:t:u:w:m:T:z:J:B:K:L:Y:N:UW:I:a:Q:V:e:v:j:y:G:O:X:F:H:o:f:l:hZ:qR:P:C:E:"; line over 96 characters