build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35889 )
Change subject: mainboard/pcengines/apu2/mainboard.c: fill SMBIOS type 16 and 17 ......................................................................
Patch Set 1:
(8 comments)
https://review.coreboot.org/c/coreboot/+/35889/1/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35889/1/src/mainboard/pcengines/apu... PS1, Line 172: switch (spd[12]) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/35889/1/src/mainboard/pcengines/apu... PS1, Line 209: if(spd[3]==0x08){ spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35889/1/src/mainboard/pcengines/apu... PS1, Line 209: if(spd[3]==0x08){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/35889/1/src/mainboard/pcengines/apu... PS1, Line 209: if(spd[3]==0x08){ space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35889/1/src/mainboard/pcengines/apu... PS1, Line 209: if(spd[3]==0x08){ braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35889/1/src/mainboard/pcengines/apu... PS1, Line 351: switch(spd_buffer[3]){ switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/35889/1/src/mainboard/pcengines/apu... PS1, Line 351: switch(spd_buffer[3]){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/35889/1/src/mainboard/pcengines/apu... PS1, Line 351: switch(spd_buffer[3]){ space required before the open parenthesis '('