EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39366 )
Change subject: lib/spd_bin: Correct LPDDR3 SPD information
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39366/3/src/lib/spd_bin.c
File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/39366/3/src/lib/spd_bin.c@36
PS3, Line 36: case SPD_DRAM_DDR3:
: case SPD_DRAM_LPDDR3_INTEL:
: return false;
: /* LPDDR3, LPDDR4 and DDR4 share the same attributes */
: case SPD_DRAM_LPDDR3_JEDEC:
: case SPD_DRAM_DDR4:
: case SPD_DRAM_LPDDR4:
: default:
: return true;
How about: […]
Sure, better.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39366
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c9361caf272ea916a3a618ee2b72a6142ffc80c
Gerrit-Change-Number: 39366
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 07 Mar 2020 16:34:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment