Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41640 )
Change subject: util/mb/google: add templates for dedede boards ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... PS1, Line 1: /* : * : * : * SPDX-License-Identifier: GPL-2.0-or-later : */
I feel this can be a single line comment. […]
Done
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory.c:
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... PS1, Line 18:
This file can be removed. […]
Done
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... File util/mainboard/google/waddledoo/template/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... PS1, Line 27: rise_time_ns = 66, : .fall_time_ns = 90, : .data_hold_time_ns = 350
The rise time, fall time and data hold time may require tuning based on individual variant boards. […]
Done