Attention is currently required from: Mike Banon, Marshall Dawson, Angel Pons, Kyösti Mälkki. Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38313 )
Change subject: AGESA,binaryPI boards: Drop invalid MP table files ......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
It would be great if you could document how to create a correct MP table for a given mainboard, and how to test it.
A good starting point is these messages (search a coreboot mailing list archive by "banon irq") https://mail.coreboot.org/hyperkitty/search?q=banon+irq&page=1&mlist... . After looking through them, temporarily flash a proprietary UEFI BIOS to your board and use a getpir utility mentioned at "https://mail.coreboot.org/hyperkitty/search?mlist=coreboot%40coreboot.org&am..." to produce the initial version of PIRQ tables, then do the lspci commands - and compare this initial PIRQ and lspci's properties of your board against the successful "a88xm-e / am1i-a / g505s".
There's a relation between the PIRQ tables, ACPI IRQ routing and MPTABLEs, so after you'll produce the initial version of PIRQ irq_tables.c - by looking at the successful examples above and the differences between the boards - it's just a matter of time to update all this stuff accordingly for it to match each other and to be suitable for your board.
Verification could be done by a hobby OS like Kolibri: if you see that the IRQs got successfully assigned to the devices and they are working, it's safe to assume you did everything correctly for them - otherwise, if some device is problematic (doesn't work in Kolibri and maybe makes a Linux kernel to print some angry messages at dmesg kernel log), change its' PIRQ / ACPI IRQ routing / MPTABLE of this device and test again.
Doing it right for g505s took me 1 month only because there weren't any good examples except am1i-a which was also far from being perfect. But after that, a88xm-e took just a couple of days and one more day to go back to fix am1i-a using this experience.