[coreboot-gerrit] New patch to review for coreboot: ecb467e x86 I/O APIC: Move dumping of I/O APIC regs to `ioapic.c`

[Paul Menzel]

Paul Menzel ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3184

-gerrit

commit ecb467ea212df74e1cf42692a66c35c048f5080d
Author: Paul Menzel 
Date:   Tue Apr 23 14:49:41 2013 +0200

x86 I/O APIC: Move dumping of I/O APIC regs to `ioapic.c`

Moving the code from the southbridges to `src/arch/x86/lib/ioapic.c`
    all boards using the function `set_ioapic_id()` get the debug feature.

Change-Id: Ic59c4c2213ed97bdf3798b3dc6e7cecc30e135d8
    Signed-off-by: Paul Menzel 
---
 src/arch/x86/lib/ioapic.c             | 6 ++++++
 src/southbridge/intel/bd82x6x/lpc.c   | 6 ------
 src/southbridge/intel/i82801gx/lpc.c  | 7 -------
 src/southbridge/intel/lynxpoint/lpc.c | 6 ------
 4 files changed, 6 insertions(+), 19 deletions(-)

diff --git a/src/arch/x86/lib/ioapic.c b/src/arch/x86/lib/ioapic.c
index 8528dd8..cc35ae3 100644
--- a/src/arch/x86/lib/ioapic.c
+++ b/src/arch/x86/lib/ioapic.c
@@ -90,6 +90,12 @@ void set_ioapic_id(u32 ioapic_base, u8 ioapic_id)
    		(io_apic_read(ioapic_base, 0x00) & 0xf0ffffff) |
    		(ioapic_id << 24));
    }
+
+	printk(BIOS_SPEW, "IOAPIC: Dumping registers\n");
+	for (i = 0; i < 3; i++)
+		printk(BIOS_SPEW, "  reg 0x%04x: 0x%08x\n", i,
+		       io_apic_read(ioapic_base, i));
+
 }

static void load_vectors(u32 ioapic_base)
diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c
index 181d36c..70a41a4 100644
--- a/src/southbridge/intel/bd82x6x/lpc.c
+++ b/src/southbridge/intel/bd82x6x/lpc.c
@@ -60,7 +60,6 @@ static void i82801gx_enable_acpi(struct device *dev)
  */
 static void i82801gx_enable_ioapic(struct device *dev)
 {
-	int i;
    u32 reg32;

set_ioapic_id(IO_APIC_ADDR, 0x02);
@@ -69,11 +68,6 @@ static void i82801gx_enable_ioapic(struct device *dev)
    reg32 = io_apic_read(IO_APIC_ADDR, 0x01);
    io_apic_write(IO_APIC_ADDR, reg32);

-	printk(BIOS_SPEW, "IOAPIC: Dumping registers\n");
-	for (i = 0; i < 3; i++)
-		printk(BIOS_SPEW, "  reg 0x%04x: 0x%08x\n", i,
-		       io_apic_read(ioapic_base, i));
-
    io_apic_write(IO_APIC_ADDR, 0x03, /* Select Boot Configuration register. */
    	      0x01); /* Use Processor System Bus to deliver interrupts. */
 }
diff --git a/src/southbridge/intel/i82801gx/lpc.c b/src/southbridge/intel/i82801gx/lpc.c
index 8be8afc..6785456 100644
--- a/src/southbridge/intel/i82801gx/lpc.c
+++ b/src/southbridge/intel/i82801gx/lpc.c
@@ -60,15 +60,8 @@ static void i82801gx_enable_acpi(struct device *dev)
  */
 static void i82801gx_enable_ioapic(struct device *dev)
 {
-	int i;
-
    set_ioapic_id(IO_APIC_ADDR, 0x02);

-	printk(BIOS_SPEW, "IOAPIC: Dumping registers\n");
-	for (i = 0; i < 3; i++)
-		printk(BIOS_SPEW, "  reg 0x%04x: 0x%08x\n", i,
-        	       io_apic_read(ioapic_base, i));
-
    io_apic_write(IO_APIC_ADDR, 0x03, /* Select Boot Configuration register. */
    	      0x01); /* Use Processor System Bus to deliver interrupts. */
 }
diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c
index 72347dc..5808222 100644
--- a/src/southbridge/intel/lynxpoint/lpc.c
+++ b/src/southbridge/intel/lynxpoint/lpc.c
@@ -64,7 +64,6 @@ static void i82801gx_enable_acpi(struct device *dev)
  */
 static void i82801gx_enable_ioapic(struct device *dev)
 {
-	int i;
    u32 reg32;

set_ioapic_id(IO_APIC_ADDR, 0x02);
@@ -73,11 +72,6 @@ static void i82801gx_enable_ioapic(struct device *dev)
    reg32 = io_apic_read(IO_APIC_ADDR, 0x01);
    io_apic_write(IO_APIC_ADDR, reg32);

-	printk(BIOS_SPEW, "IOAPIC: Dumping registers\n");
-	for (i = 0; i < 3; i++)
-		printk(BIOS_SPEW, "  reg 0x%04x: 0x%08x\n", i,
-		       io_apic_read(ioapic_base, i));
-
    io_apic_write(IO_APIC_ADDR, 0x03, /* Select Boot Configuration register. */
    	      0x01); /* Use Processor System Bus to deliver interrupts. */
 }