Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33549 )
Change subject: sb/intel/bd82x6x/lpc: Set up default LPC decode ranges ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33549/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33549/4//COMMIT_MSG@7 PS4, Line 7: Setup
Set up
Done
https://review.coreboot.org/c/coreboot/+/33549/4/src/mainboard/asrock/b75pro... File src/mainboard/asrock/b75pro3-m/romstage.c:
https://review.coreboot.org/c/coreboot/+/33549/4/src/mainboard/asrock/b75pro... PS4, Line 29: LPT_LPC_EN
this decode is missing in the common code […]
Done
https://review.coreboot.org/c/coreboot/+/33549/4/src/mainboard/google/link/r... File src/mainboard/google/link/romstage.c:
https://review.coreboot.org/c/coreboot/+/33549/4/src/mainboard/google/link/r... PS4, Line 39: GAMEL_LPC_EN
is this really used? if not, this can also be dropped […]
Ack
https://review.coreboot.org/c/coreboot/+/33549/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/early_pch.c:
https://review.coreboot.org/c/coreboot/+/33549/1/src/southbridge/intel/bd82x... PS1, Line 293: pch_enable_lpc();
one option is to get rid of this an provide an option in the devicetree to override the default deco […]
Ack