[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/meteorlake: Validate CPU crashlog discovery table and records

[Pratikkumar V Prajapati (Code Review)]

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Paul Menzel, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli, Tracy Wu.

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76333?usp=email )

Change subject: soc/intel/meteorlake: Validate CPU crashlog discovery table and records
......................................................................

Patch Set 14:

(2 comments)

File src/soc/intel/meteorlake/crashlog.c:

https://review.coreboot.org/c/coreboot/+/76333/comment/61d17754_123e59a3 :
PS13, Line 403: printk(BIOS_DEBUG, "cpu crashlog records already consumed."
              : 						"id: 0x%x dw0: 0x%x\n", i, dw0);
> Message says `records` but only one ID is passed. […]

If any of the records is consumed i am breaking out of loop as all the `records` are considered consumed. So message seems good.

File src/soc/intel/meteorlake/include/soc/crashlog.h:

https://review.coreboot.org/c/coreboot/+/76333/comment/78d3d1c9_f81e1c66 :
PS13, Line 21: 0x1
> `(1 << 31)` should be enough here or you can use `BIT(31)` from `types.h` instead.

Done