Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47757 )
Change subject: soc/intel/block/pmclib.c: Properly guard apm_control()
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47757/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/47757/1/src/soc/intel/common/block/...
PS1, Line 716: if (!CONFIG(NO_SMM) && !acpi_is_wakeup_s3()) {
braces {} are not necessary for single statement blocks
Jenkins is right
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47757
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e0fc7433a9226825f5ae4903c0ff2e0162d86ac
Gerrit-Change-Number: 47757
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 19 Nov 2020 16:41:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment