Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44704 )
Change subject: soc/mediatek/mt8192: Do dramc software impedance calibration ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44704/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44704/1/src/soc/mediatek/mt8192/dra... PS1, Line 3: string
not used ?
memcpy will call later, so can't remove it. the final file is https://review.coreboot.org/plugins/gitiles/coreboot/+/5c76c7f4ac37023a367f3...
https://review.coreboot.org/c/coreboot/+/44704/1/src/soc/mediatek/mt8192/dra... PS1, Line 6: timer.h>
is it used ?
wait_us will call later, so can't remove it. the final file is https://review.coreboot.org/plugins/gitiles/coreboot/+/5c76c7f4ac37023a367f3...