build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34512 )
Change subject: mb/google/octopus: Override VBT selection for Dorp ......................................................................
Patch Set 1:
(11 comments)
https://review.coreboot.org/c/coreboot/+/34512/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/meep/variant.c:
https://review.coreboot.org/c/coreboot/+/34512/1/src/mainboard/google/octopu... PS1, Line 30: case SKU_33_DORP: 'DORP' may be misspelled - perhaps 'DROP'?
https://review.coreboot.org/c/coreboot/+/34512/1/src/mainboard/google/octopu... PS1, Line 31: case SKU_34_DORP: 'DORP' may be misspelled - perhaps 'DROP'?
https://review.coreboot.org/c/coreboot/+/34512/1/src/mainboard/google/octopu... PS1, Line 31: case SKU_34_DORP: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34512/1/src/mainboard/google/octopu... PS1, Line 31: case SKU_34_DORP: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34512/1/src/mainboard/google/octopu... PS1, Line 32: case SKU_35_DORP: 'DORP' may be misspelled - perhaps 'DROP'?
https://review.coreboot.org/c/coreboot/+/34512/1/src/mainboard/google/octopu... PS1, Line 32: case SKU_35_DORP: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34512/1/src/mainboard/google/octopu... PS1, Line 32: case SKU_35_DORP: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34512/1/src/mainboard/google/octopu... PS1, Line 33: case SKU_36_DORP: 'DORP' may be misspelled - perhaps 'DROP'?
https://review.coreboot.org/c/coreboot/+/34512/1/src/mainboard/google/octopu... PS1, Line 33: case SKU_36_DORP: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34512/1/src/mainboard/google/octopu... PS1, Line 33: case SKU_36_DORP: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34512/1/src/mainboard/google/octopu... PS1, Line 34: return "vbt_dorp_hdmi.bin"; 'dorp' may be misspelled - perhaps 'drop'?