Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45732/11/src/mainboard/google/deded...
File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45732/11/src/mainboard/google/deded...
PS11, Line 64: register "group" = "ACPI_PLD_GROUP(2, 2)"
Done. I have removed it. Thanks.
Sorry I meant to remove only the line:
register "group" = "ACPI_PLD_GROUP(2, 2)"
That configuration is meant for user-visible USB ports. The rest of the configuration is required:
chip drivers/usb/acpi
register "desc" = ""LTE""
register "type" = "UPC_TYPE_INTERNAL"
device usb 3.3 on end
end
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45732
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2
Gerrit-Change-Number: 45732
Gerrit-PatchSet: 12
Gerrit-Owner: Alec Wang
alec.wang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Alec Wang
alec.wang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ben Kao
ben.kao@intel.com
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Wed, 30 Sep 2020 06:03:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alec Wang
alec.wang@lcfc.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment