Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41334 )
Change subject: soc/intel/common: Improve Type16 SMBIOS tables
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41334/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41334/1//COMMIT_MSG@14
PS1, Line 14: * Assume the same bits for Tiger Lake as for Ice Lake
yes
I’d love to have this mentioned in the commit message. But up to you.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41334
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d8fbb512fccbd99a6cfdacadc496d8266ae4cc7
Gerrit-Change-Number: 41334
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 May 2020 12:05:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment