Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42257 )
Change subject: soc/intel/*/acpi: Put braces around *else* branch ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42257/2/src/soc/intel/jasperlake/ac... File src/soc/intel/jasperlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/42257/2/src/soc/intel/jasperlake/ac... PS2, Line 293: gnvs->chromeos.vbt2 = google_ec_running_ro() ? : ACTIVE_ECFW_RO : ACTIVE_ECFW_RW;
This is technically one statement. […]
Well, it uses multiple lines, so using braces makes the code clearer (even if only slightly).
But hey, we could also make everything a single statement!
gnvs->chromeos.vbt2 = !CONFIG(EC_GOOGLE_CHROMEEC) || google_ec_running_ro() ? ACTIVE_ECFW_RO : ACTIVE_ECFW_RW;
(not that I would like it)