Attention is currently required from: Nico Huber, Subrata Banik, Michael Niewöhner, EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49021 )
Change subject: soc/intel/alderlake: Update PCH and CPU PCIe RP table
......................................................................
Patch Set 8:
(2 comments)
File src/soc/intel/alderlake/pcie_rp.c:
https://review.coreboot.org/c/coreboot/+/49021/comment/b84c252a_c5da20f7
PS8, Line 18: static const struct pcie_rp_group cpu_rp_groups[] = {
Can you please add a comment here indicating that this order is basically aligned with FSP expectations for the CPU PCIe UPD?
https://review.coreboot.org/c/coreboot/+/49021/comment/d998634a_5b42e478
PS8, Line 21: { .slot = SA_DEV_SLOT_CPU_6, .start = 2, .count = 1 },
This table needs to end with { 0 }.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49021
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcc21d8028f51a221d639440db4cf5a4e095c632
Gerrit-Change-Number: 49021
Gerrit-PatchSet: 8
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 13 Jan 2021 18:18:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment