Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49016 )
Change subject: device: Select VGA_ROM_RUN for non-FSP solution with PCIE DGPU ......................................................................
device: Select VGA_ROM_RUN for non-FSP solution with PCIE DGPU
For onboard graphics initialization, GFX PEIM module inside FSP binary is taking care of graphics initialization based on HAVE_FSP_GOP Kconfig option and input VBT file. Hence no need to load/execute legacy VGA OpROM in order to initialize onboard GFX.
In case of non-FSP solution, platform need to select VGA_ROM_RUN Kconfig to perform graphics initialization for PCI-E based discrete card through VGA OpRom (SoC or Mainboard user can't select VGA_ROM_RUN directly because it's part of choice option).
TEST=Able to get Pre-OS splash screen with PCI-E DGPU when SoC user doesn't select HAVE_FSP_GOP.
Change-Id: Iecb2fcdb105af449bc20ad727759cdef17d5e376 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/device/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/49016/1
diff --git a/src/device/Kconfig b/src/device/Kconfig index a472a6a..b93330c 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -81,7 +81,7 @@ # TODO: Explain differences (if any) for onboard cards. config VGA_ROM_RUN bool "Run VGA Option ROMs" - depends on PCI && (ARCH_X86 || ARCH_PPC64) && !MAINBOARD_FORCE_NATIVE_VGA_INIT + depends on PCI && (ARCH_X86 || ARCH_PPC64) && !HAVE_FSP_GOP && !MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_VGA_TEXT_FRAMEBUFFER help Execute VGA Option ROMs in coreboot if found. This can be used