[coreboot-gerrit] Change in coreboot[master]: mb/ocp/deltalake: Update SMBIOS type 7 -- Cache Information

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44059 )

Change subject: mb/ocp/deltalake: Update SMBIOS type 7 -- Cache Information
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44059/3/src/arch/x86/smbios.c 
File src/arch/x86/smbios.c:

https://review.coreboot.org/c/coreboot/+/44059/3/src/arch/x86/smbios.c@855 
PS3, Line 855: 		t->max_cache_size *= core_count;
As far as I understand only caches that aren't shared between cores can be accumulated here.

https://review.coreboot.org/c/coreboot/+/44059/3/src/arch/x86/smbios.c@984 
PS3, Line 984: 		if (level == 1 && type == SMBIOS_CACHE_TYPE_DATA) {
that's not what CPUID reports. Why do you think CPUID isn't correct?