Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38779 )
Change subject: vboot: push clear recovery mode switch until BS_WRITE_TABLES
......................................................................
Patch Set 11:
(1 comment)
Ready for commit after fixing nit
https://review.coreboot.org/c/coreboot/+/38779/9/src/ec/google/chromeec/swit...
File src/ec/google/chromeec/switches.c:
https://review.coreboot.org/c/coreboot/+/38779/9/src/ec/google/chromeec/swit...
PS9, Line 76: return 0;
nit: why are we no longer returning the status here? I think we should either change the function si […]
Unintentional... let me pass the value through.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38779
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30c02787c620b937e5a50a5ed94ac906e3112dad
Gerrit-Change-Number: 38779
Gerrit-PatchSet: 11
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kangheui Won
khwon@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 15 Feb 2020 05:43:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment