Attention is currently required from: Matt DeVillier, Duncan Laurie, Angel Pons.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48787 )
Change subject: [WIP] soc/intel/broadwell: Skip PRE_GRAPHICS_DELAY
......................................................................
Patch Set 6:
(3 comments)
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/48787/comment/807958d6_d62d1c2d
PS6, Line 712: should_run = display_init_required();
VBOOT telling to skip run_bios() is detected here.
https://review.coreboot.org/c/coreboot/+/48787/comment/0a6f483e_6717bf92
PS6, Line 747: return;
Delay only with VGA_ROM_RUN.
File src/soc/intel/broadwell/gma.c:
https://review.coreboot.org/c/coreboot/+/48787/comment/b287f999_be24ab4f
PS2, Line 516: if (!acpi_is_wakeup_s3()) {
: if (!CONFIG(CHROMEOS) || display_init_required())
in that case we'd want it conditional on VGA_RUN_ROM, and not always true for the non-VBOOT case
Matt, I added comments in patchset #6? It adds the VGA_ROM_RUN conditionality.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4503158576f35057373f003586bbf76af4d59b3d
Gerrit-Change-Number: 48787
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Duncan Laurie
dlaurie@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 04 Feb 2021 15:14:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment