[coreboot-gerrit] Change in coreboot[master]: superio/common: Validate devicetree

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38863 )

Change subject: superio/common: Validate devicetree
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/38863/2/src/superio/common/ssdt.c 
File src/superio/common/ssdt.c:

https://review.coreboot.org/c/coreboot/+/38863/2/src/superio/common/ssdt.c@1... 
PS2, Line 167: const u8 ldn = dev->path.pnp.device & 0xff;
             : 	const u8 vldn = (dev->path.pnp.device >> 8) & 0x7;
here *dev already gets dereferenced, the check that dev isn't 0 probably should be before and not after this