Attention is currently required from: Arthur Heymans, Julius Werner, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Nick Vaccaro, Subrata Banik, Werner Zeh.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78078?usp=email )
Change subject: drivers/intel/gma: Update port select bit definitions
......................................................................
Patch Set 1:
(3 comments)
File src/drivers/intel/gma/i915_reg.h:
https://review.coreboot.org/c/coreboot/+/78078/comment/fd3f52b5_14e3f71f :
PS1, Line 4185: #define TRANS_DDI_PORT_SHIFT 27
Code Style Nits: No need for indentation?
https://review.coreboot.org/c/coreboot/+/78078/comment/621e58ad_ef12f15d :
PS1, Line 4191: <<
Nit: Space before and after `<<`
https://review.coreboot.org/c/coreboot/+/78078/comment/fcc5d3d6_edb6a14a :
PS1, Line 4194: <<
Same comment as above
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78078?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I815ffa90c2e235afd70baa7e3837e1f9af89b1b0
Gerrit-Change-Number: 78078
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 26 Sep 2023 20:27:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment