Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35803 )
Change subject: mb/google/hatch: Preserve MRC training data across FW update
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35803/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35803/1//COMMIT_MSG@7
PS1, Line 7: Preserve MRC training data across FW update
The reason we're doing this is because after we do a FW update, it takes awhile to boot to kernel (l […]
Fifteen seconds to do memory init? O_o
I can see why such a delay is unwanted: impatient users could wrongfully conclude their device is not booting anymore after a FW update. Could you please add this to the commit message? Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35803
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5eb228b1f665a8371982544723dab3dfc40d401
Gerrit-Change-Number: 35803
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 05 Oct 2019 09:35:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment